arrow icon indicating copy to clipboard operation
arrow copied to clipboard

GH-46207: [C++] Rename arrow::util::StringBuilder and move to internal namespace

Open Ziy1-Tan opened this issue 6 months ago • 1 comments

Rationale for this change

  • Move and Rename function arrow::util::StringBuilder to internal namespace to avoid confusion with class arrow::StringBuilder

What changes are included in this PR?

  • Move arrow::util::StringBuilder to arrow::internal::StringBuilder
  • Rename arrow::internal::StringBuilder to arrow::internal::JoinToString
  • Rename arrow/util/string_builder.{h|cc} to arrow/util/string_util_internal.{h|cc}

Are these changes tested?

Yes.

Are there any user-facing changes?

No. they are used internally.

  • GitHub Issue: #46207

Ziy1-Tan avatar Jun 14 '25 00:06 Ziy1-Tan

Thanks for tackling the work. Part of the current problem on CI is with calling the file *_internal.h . The header file won't be installed and this is used on some of the bindings which requires it. We can move the namespace to arrow::internal but keep installing the header file, probably naming the files string_util.cc and string_util.h?

Thank you for your review. Let me take a look.

Ziy1-Tan avatar Jun 16 '25 14:06 Ziy1-Tan

@github-actions crossbow submit -g cpp

pitrou avatar Jul 01 '25 08:07 pitrou

Revision: b9c5e4d0a0a5a4ac88ff033aab74586091c0222a

Submitted crossbow builds: ursacomputing/crossbow @ actions-44ea48c19a

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

github-actions[bot] avatar Jul 01 '25 08:07 github-actions[bot]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1202d79fbafedfef77c5df2abd94abf2e3a7d06c.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details.

@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155

kou avatar Jul 04 '25 04:07 kou

Revision: b9c5e4d0a0a5a4ac88ff033aab74586091c0222a

Submitted crossbow builds: ursacomputing/crossbow @ actions-21818136da

Task Status
test-r-rstudio-r-base-4.1-opensuse155 Azure

github-actions[bot] avatar Jul 04 '25 04:07 github-actions[bot]