GH-46207: [C++] Rename arrow::util::StringBuilder and move to internal namespace
Rationale for this change
- Move and Rename function
arrow::util::StringBuilderto internal namespace to avoid confusion with classarrow::StringBuilder
What changes are included in this PR?
- Move
arrow::util::StringBuildertoarrow::internal::StringBuilder - Rename
arrow::internal::StringBuildertoarrow::internal::JoinToString - Rename
arrow/util/string_builder.{h|cc}toarrow/util/string_util_internal.{h|cc}
Are these changes tested?
Yes.
Are there any user-facing changes?
No. they are used internally.
- GitHub Issue: #46207
Thanks for tackling the work. Part of the current problem on CI is with calling the file
*_internal.h. The header file won't be installed and this is used on some of the bindings which requires it. We can move the namespace toarrow::internalbut keep installing the header file, probably naming the filesstring_util.ccandstring_util.h?
Thank you for your review. Let me take a look.
@github-actions crossbow submit -g cpp
Revision: b9c5e4d0a0a5a4ac88ff033aab74586091c0222a
Submitted crossbow builds: ursacomputing/crossbow @ actions-44ea48c19a
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1202d79fbafedfef77c5df2abd94abf2e3a7d06c.
There was 1 benchmark result indicating a performance regression:
- Commit Run on
amd64-m5-4xlarge-linuxat 2025-07-01 12:34:45Z
The full Conbench report has more details.
@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155
Revision: b9c5e4d0a0a5a4ac88ff033aab74586091c0222a
Submitted crossbow builds: ursacomputing/crossbow @ actions-21818136da
| Task | Status |
|---|---|
| test-r-rstudio-r-base-4.1-opensuse155 |