apache
GH-46740: [C++] Update bundled Thrift to 0.22.0
Rationale for this change
Apache Thrift 0.22.0 has been released: https://github.com/apache/thrift/releases/tag/v0.22.0
What changes are included in this PR?
Update bundled Thrift version.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
- GitHub Issue: #46740
:warning: GitHub issue #46740 has been automatically assigned in GitHub to PR creator.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Revision: 22e86621bb7fe4f2b40678db9e9d121616a5b111
Submitted crossbow builds: ursacomputing/crossbow @ actions-e66c94ae55
| Task | Status |
|---|---|
| example-cpp-minimal-build-static |  |
| example-cpp-minimal-build-static-system-dependency |  |
| example-cpp-tutorial |  |
| example-python-minimal-build-fedora-conda |  |
| example-python-minimal-build-ubuntu-venv |  |
| r-binary-packages |  |
| r-recheck-most |  |
| test-build-cpp-fuzz |  |
| test-conda-cpp |  |
| test-conda-cpp-valgrind |  |
| test-conda-python-3.10 |  |
| test-conda-python-3.10-hdfs-2.9.2 |  |
| test-conda-python-3.10-hdfs-3.2.1 |  |
| test-conda-python-3.10-pandas-latest-numpy-latest |  |
| test-conda-python-3.11 |  |
| test-conda-python-3.11-dask-latest |  |
| test-conda-python-3.11-dask-upstream_devel |  |
| test-conda-python-3.11-hypothesis |  |
| test-conda-python-3.11-pandas-latest-numpy-1.26 |  |
| test-conda-python-3.11-pandas-latest-numpy-latest |  |
| test-conda-python-3.11-pandas-nightly-numpy-nightly |  |
| test-conda-python-3.11-pandas-upstream_devel-numpy-nightly |  |
| test-conda-python-3.11-spark-master |  |
| test-conda-python-3.12 |  |
| test-conda-python-3.12-cpython-debug |  |
| test-conda-python-3.13 |  |
| test-conda-python-3.9 |  |
| test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 |  |
| test-conda-python-emscripten |  |
| test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 |  |
| test-cuda-python-ubuntu-22.04-cuda-11.7.1 |  |
| test-debian-12-cpp-amd64 |  |
| test-debian-12-cpp-i386 |  |
| test-debian-12-python-3-amd64 |  |
| test-debian-12-python-3-i386 |  |
| test-fedora-39-cpp |  |
| test-fedora-39-python-3 |  |
| test-r-arrow-backwards-compatibility |  |
| test-r-depsource-bundled | |
| test-r-depsource-system |  |
| test-r-dev-duckdb |  |
| test-r-devdocs |  |
| test-r-extra-packages |  |
| test-r-gcc-11 |  |
| test-r-gcc-12 |  |
| test-r-install-local |  |
| test-r-install-local-minsizerel |  |
| test-r-linux-as-cran |  |
| test-r-linux-rchk |  |
| test-r-linux-sanitizers |  |
| test-r-linux-valgrind |  |
| test-r-m1-san |  |
| test-r-macos-as-cran |  |
| test-r-minimal-build | |
| test-r-offline-maximal |  |
| test-r-offline-minimal | |
| test-r-rhub-debian-gcc-devel-lto-latest | |
| test-r-rhub-debian-gcc-release-custom-ccache | |
| test-r-rhub-ubuntu-release-latest | |
| test-r-rocker-r-ver-latest | |
| test-r-rstudio-r-base-4.1-opensuse155 | |
| test-r-rstudio-r-base-4.2-focal | |
| test-r-ubuntu-22.04 |  |
| test-r-versions |  |
| test-ubuntu-22.04-cpp |  |
| test-ubuntu-22.04-cpp-20 |  |
| test-ubuntu-22.04-cpp-bundled |  |
| test-ubuntu-22.04-cpp-emscripten |  |
| test-ubuntu-22.04-cpp-no-threading |  |
| test-ubuntu-22.04-python-3 |  |
| test-ubuntu-22.04-python-313-freethreading |  |
| test-ubuntu-24.04-cpp |  |
| test-ubuntu-24.04-cpp-bundled-offline |  |
| test-ubuntu-24.04-cpp-gcc-13-bundled |  |
| test-ubuntu-24.04-cpp-gcc-14 |  |
| test-ubuntu-24.04-cpp-minimal-with-formats |  |
| test-ubuntu-24.04-cpp-thread-sanitizer |  |
| test-ubuntu-24.04-python-3 |  |
Hmm...
https://github.com/ursacomputing/crossbow/actions/runs/15529087541/job/43714065005#step:3:1300
-- stderr output is:
In file included from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TApplicationException.h:23,
from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TApplicationException.cpp:20:
/build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:54:19: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
54 | : public std::iterator<std::forward_iterator_tag, std::pair<int, const char*> > {
| ^~~~~~~~
In file included from /usr/include/c++/13/bits/stl_iterator_base_funcs.h:66,
from /usr/include/c++/13/string:47,
from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:37:
/usr/include/c++/13/bits/stl_iterator_base_types.h:127:34: note: declared here
127 | struct _GLIBCXX17_DEPRECATED iterator
| ^~~~~~~~
In file included from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TOutput.cpp:20:
/build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:54:19: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
54 | : public std::iterator<std::forward_iterator_tag, std::pair<int, const char*> > {
| ^~~~~~~~
In file included from /usr/include/c++/13/bits/stl_iterator_base_funcs.h:66,
from /usr/include/c++/13/string:47,
from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:37:
/usr/include/c++/13/bits/stl_iterator_base_types.h:127:34: note: declared here
127 | struct _GLIBCXX17_DEPRECATED iterator
| ^~~~~~~~
/build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TUuid.cpp:22:10: fatal error: boost/uuid/string_generator.hpp: No such file or directory
22 | #include <boost/uuid/string_generator.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
std::iterator: Issue and PR are available:
- https://issues.apache.org/jira/browse/THRIFT-5698
- https://github.com/apache/thrift/pull/2778
But the PR closed because of no response from maintainers.
@kou are we waiting for a 0.23.0 (or 0.22.1) version of Thrift? or should we apply the upstream patches that have been merged? Updating the version might fix the flaky issues we get downloading old Thrift.
Ah, sorry. https://github.com/apache/arrow/issues/46745 is the blocker of this. I had a plan to work on #46745 after https://github.com/apache/arrow/pull/45306 is merged but I haven't worked on it yet.
@kou are we waiting for a 0.23.0 (or 0.22.1) version of Thrift? or should we apply the upstream patches that have been merged? Updating the version might fix the flaky issues we get downloading old Thrift.
I think we can definitely wait for a fixed Thrift release.
std::iterator is a warning not an error. So it's not a blocker of this. We can use Thrift 0.22.0 (that doesn't include the changes for std::iterator).
boost/uuid is a blocker because our CMake configuration for Boost doesn't find boost/uuid.
(Sorry, not working on this yet...)
I close this in favor of #46912. #46912 updates bundled Boost and Apache Thrift. I want to update them separately but there are coupled. So I couldn't do it.