arrow icon indicating copy to clipboard operation
arrow copied to clipboard

GH-44231: [Python] Add tests for test_compute

Open Isaac7777-cpu-school opened this issue 1 year ago • 2 comments

Rationale for this change

This change is to address issue #44231 in which indicates that there is lacking coverage of the test cases for test_compute.py.

What changes are included in this PR?

Changes according to the issue:

  • Added negative values for int8, int16, int32, int64, float, double. I have also added in negative values for test cases in pa.list_ and pa.large_list_
  • I have added pa.decimal128 and pa.decimal256 in all_array_types.

Further changes:

Apart from the problems mentioned in the issue, I have also extended some of the tests for pa.decimal128 and pa.decimal256. Currently, the numerical_arrow_types does not contain decimal. However, some of the functions that are tested for the numerical_arrow_types should also be tested for both decimal types. Therefore, I have duplicated similar tests but rewritten using decimals.

Looking to close #44231

Are these changes tested?

Yes, these changes are tests by my fork repository CI. However, as I am new to open source contributing, I am not sure if I have missed anything. I apologise if I do so.

Are there any user-facing changes?

No.

  • GitHub Issue: #44231

Isaac7777-cpu-school avatar Oct 14 '24 23:10 Isaac7777-cpu-school