arrow icon indicating copy to clipboard operation
arrow copied to clipboard

Unexpected `benchmark` module get installed with arrow

Open noklam opened this issue 1 year ago • 0 comments

Describe the bug, including details regarding any error messages, version, and platform.

Uninstalling benchmarks-0.1.0: Would remove: /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks-0.1.0.dist-info/* /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/* Would not remove (might be manually added): /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/array_ops.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/common.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/convert_builtins.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/convert_pandas.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/io.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/microbenchmarks.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/parquet.py /Users/Nok_Lam_Chan/miniconda3/envs/kedro/lib/python3.10/site-packages/benchmarks/streaming.py

Context:

I am trying to use asv for benchmarking and seems that the PyArrow project also use this: https://github.com/apache/arrow/tree/main/python/benchmarks

More evidence:

I've downloaded the latest package from Pypi: https://pypi.org/project/pyarrow/#files, and unzip the folder locally. image

I found this document discuss the benchmarks folder. It makes sense to have this in the source code, but it doesn't make sense to me to include this into the python package. Since the way that it works you need to run asv run so user are expected to run this with source code.

Suggestion

Is this necessary to be packaged into the pyarrow library? If this is unexpected, I can raise a PR to fix this. I think the change would be excluding the benchmarks from packaging the pyarrow library.

Component(s)

Benchmarking, Developer Tools, Python

noklam avatar Oct 14 '24 15:10 noklam