arrow icon indicating copy to clipboard operation
arrow copied to clipboard

[Packaging] soversion bumps on minor releases

Open jtanx opened this issue 1 year ago • 7 comments

Describe the usage question you have. Please include as many useful details as possible.

Hi, the latest release of pyarrow bumps the soversion to 1601. It's painful enough that the soversion bumps with every major release, but is there a need to bump the soversion on minor releases? Are breaking abi changes really being released on minor releases?

Component(s)

Python

jtanx avatar May 15 '24 00:05 jtanx

@pitrou What do you think about this? FYI: #4801 for the current versioning schema.

kou avatar May 16 '24 00:05 kou

We're not supposed to break the ABI in bugfix releases, so I don't know why the soversion was bumped.

pitrou avatar May 16 '24 06:05 pitrou

The latest 16.1.0 release was not a bug-fix release, but a minor / feature release, though (and the first time we ever did this since 1.0, AFAIK, so I don't know if we have explicit expectations around this, I personally would expect that a feature release is not ABI stable)

jorisvandenbossche avatar May 16 '24 07:05 jorisvandenbossche

Ah, right. Well, 16.1.0 is a slightly unusual case then.

pitrou avatar May 16 '24 07:05 pitrou

Imo if this is going to be a breaking abi change it might as well be a major version bump

jtanx avatar May 16 '24 07:05 jtanx

To be clear, we explicitly decided to bump the so version for minor feature releases at the time of the first 1.0.0 release. See this issue Kou linked above (https://github.com/apache/arrow/pull/4801) and this email thread: https://lists.apache.org/thread/r1ztq38xz5tn4p4v0xc1xk2d8x82p84v)

jorisvandenbossche avatar May 17 '24 09:05 jorisvandenbossche

I opened an issue about that we need to better document the expectations: https://github.com/apache/arrow/issues/41707

jorisvandenbossche avatar May 17 '24 12:05 jorisvandenbossche

Let's close this in favor of discussing it further in https://github.com/apache/arrow/issues/41707

jorisvandenbossche avatar May 21 '24 09:05 jorisvandenbossche