arrow icon indicating copy to clipboard operation
arrow copied to clipboard

Published 20 hours ago • verified publisher icon apache

GH-40308: [C++][Gandiva] Keep decimal divide rules same with normal expressions

Open ZhangHuiGui opened this issue 11 months ago • 1 comments

Rationale for this change

Keep gandiva decimal divide rules same with normal expressions.

What changes are included in this PR?

Change the divide scale calculate rules to Redshift's decimal promotion rules

Are these changes tested?

Yes

Are there any user-facing changes?

No

  • GitHub Issue: #40308

ZhangHuiGui avatar Mar 09 '24 10:03 ZhangHuiGui

:warning: GitHub issue #40308 has been automatically assigned in GitHub to PR creator.

github-actions[bot] avatar Mar 09 '24 10:03 github-actions[bot]

@niyue @js8544 Could you take a look at this?

kou avatar Mar 15 '24 01:03 kou

@kou Can this PR be moved forward?

ZhangHuiGui avatar Mar 20 '24 14:03 ZhangHuiGui

@kou Seems it's ready to be merged?

ZhangHuiGui avatar Mar 25 '24 04:03 ZhangHuiGui

Merged!

kou avatar Mar 25 '24 05:03 kou

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit f100eff39fd37538c5ab4572083029622fc0f5aa.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

conbench-apache-arrow[bot] avatar Mar 25 '24 11:03 conbench-apache-arrow[bot]