arrow
arrow copied to clipboard
GH-40398: [C++] Expose protobuf dependency if opentelemetry or ORC are enabled
Rationale for this change
When not bundling dependencies, libarrow.a
depends on protobuf symbols if built with ORC or opentelemetry support. However this dependency was not looked up in ArrowConfig.cmake, causing client projects using linking to arrow_static
to fail in configuration.
What changes are included in this PR?
This change makes it so that the dependency on protobuf
is propagated to the installed ArrowConfig.cmake
file when necessary.
- GitHub Issue: #40398
:warning: GitHub issue #40398 has been automatically assigned in GitHub to PR creator.
The CI failures seem unrelated. Anything I can do to move this forward?
We can resolve these failures by rebasing on main. But I'll merge this.
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5baca0f16e924c42741729f041b31a02883548b9.
There were 2 benchmark results indicating a performance regression:
- Commit Run on
ursa-i9-9960x
at 2024-03-15 14:29:13Z
The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.