arrow GH-40395: [C++] Avoid simplifying expressions which call impure functions

Rationale for this change

Fix a problem when we call SimplifyWithGuarantee evaluate a function call which has no arguments.

What changes are included in this PR?

Check empty for call.arguments before we evaluate arguments as literal in FoldConstants.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: #40395

Mar 07 '24 06:03 ZhangHuiGui

:x: GitHub issue #40935 could not be retrieved.

Mar 07 '24 06:03 github-actions[bot]

:x: GitHub issue #40935 could not be retrieved.

Mar 07 '24 06:03 github-actions[bot]

:warning: GitHub issue #40395 has been automatically assigned in GitHub to PR creator.

Mar 07 '24 06:03 github-actions[bot]

cc @bkietz PTAL?

Mar 08 '24 02:03 ZhangHuiGui

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit d10f468b0603da41a285c60a38b095a30b91e2c1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Mar 14 '24 07:03 conbench-apache-arrow[bot]