arrow icon indicating copy to clipboard operation
arrow copied to clipboard

GH-37720: [Format][Docs][FlightSQL] Document stateless prepared statements

Open erratic-pattern opened this issue 1 year ago • 5 comments

documents changes for stateless management of FlightSQL prepared statement handles based on the design proposal described in apache/arrow#37720

  • GitHub Issue: #37720

PRs for language implementations:

  • Rust: apache/arrow-rs#5433
  • Go: apache/arrow#40311

Mailing list discussion: https://lists.apache.org/thread/3kb82ypx99q96g84qv555l6x8r0bppyq

erratic-pattern avatar Feb 26 '24 16:02 erratic-pattern

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

github-actions[bot] avatar Feb 26 '24 16:02 github-actions[bot]

:warning: GitHub issue #37720 has been automatically assigned in GitHub to PR creator.

github-actions[bot] avatar Mar 01 '24 19:03 github-actions[bot]

Will we need to extend the schema of the PutResult message in order to encapsulate the DoPutPreparedStatementResult payload?

This is the spec right now:

service FlightService {
  rpc DoPut(stream FlightData) returns (stream PutResult) {}
}

message PutResult {
  bytes app_metadata = 1;
}

I don't think the response would be considered app_metadata.

joellubi avatar Mar 11 '24 19:03 joellubi

The "app" in this case is Flight SQL. (Someday I would like to fuse Flight SQL/Flight RPC to avoid these odd distinctions, and so that we aren't multiplexing a dozen different calls into the same endpoint...)

lidavidm avatar Mar 11 '24 20:03 lidavidm

With that framing it makes sense, thanks @lidavidm.

joellubi avatar Mar 11 '24 20:03 joellubi

This proposal was approved on the Arrow dev mailing list. See thread here

erratic-pattern avatar Mar 24 '24 17:03 erratic-pattern

Thank you everyone for your feedback and participation in the process

alamb avatar Mar 25 '24 11:03 alamb

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2b0427559d94fb25ce61672c1ed17fc245d0a546.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.