arrow icon indicating copy to clipboard operation
arrow copied to clipboard

GH-39982: [Java] Add RunEndEncodedVector

Open danepitkin opened this issue 1 year ago • 3 comments

WIP

Rationale for this change

Add REE vectors to the Java implementation as per the Arrow spec.

What changes are included in this PR?

WIP

Are these changes tested?

WIP

Are there any user-facing changes?

Yes, additional features are added.

  • GitHub Issue: #39982

danepitkin avatar Feb 07 '24 17:02 danepitkin

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

github-actions[bot] avatar Feb 07 '24 17:02 github-actions[bot]

@danepitkin Ping me when you need a review.

felipecrv avatar Feb 22 '24 03:02 felipecrv

:warning: GitHub issue #39982 has been automatically assigned in GitHub to PR creator.

github-actions[bot] avatar Mar 07 '24 21:03 github-actions[bot]

Hi, @danepitkin I am really looking forward to this feature. Is this PR ready to be reviewed?

ViggoC avatar May 22 '24 13:05 ViggoC

Hi @ViggoC , no this has been paused on my end for quite some time. I might be able to work on it for the Arrow v18 release. Feel free to take it over if needed earlier!

danepitkin avatar May 22 '24 14:05 danepitkin

@danepitkin I can do that, but I have no idea how to add a new vector. Would you point me to some reading material, or just left some TODO comment to show me which part need to be implemented.

ViggoC avatar Jun 07 '24 17:06 ViggoC

@danepitkin I can do that, but I have no idea how to add a new vector. Would you point me to some reading material, or just left some TODO comment to show me which part need to be implemented.

Take a look at @vibhatha PRs and find the PRs where he is adding support for StringView to the Java implementation.

felipecrv avatar Jun 07 '24 17:06 felipecrv

@felipecrv thanks for your info.

ViggoC avatar Jun 07 '24 18:06 ViggoC