arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-2651: [Python] patch datetime C-api for PyPy

Open mattip opened this issue 3 years ago • 2 comments

As described in the ARROW-2651 issue, this patch fixes the C datetime module import mechanism for PyPy.

This is related to #2089 which was closed in favor of the JIRA issue.

mattip avatar Oct 28 '22 12:10 mattip

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

github-actions[bot] avatar Oct 28 '22 13:10 github-actions[bot]

https://issues.apache.org/jira/browse/ARROW-2651

github-actions[bot] avatar Oct 28 '22 15:10 github-actions[bot]

I see that CI passed on your fork. Failures here are unrelated.

pitrou avatar Oct 31 '22 18:10 pitrou

Thanks!

mattip avatar Oct 31 '22 19:10 mattip

Benchmark runs are scheduled for baseline = 11647857b2860973d4b99cd5d9e7132010089469 and contender = 2a5c773611e1d30c1a1a9503f9640565110d96bc. 2a5c773611e1d30c1a1a9503f9640565110d96bc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Failed :arrow_down:0.0% :arrow_up:0.0%] test-mac-arm [Finished :arrow_down:0.0% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.57% :arrow_up:0.11%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 2a5c7736 ec2-t3-xlarge-us-east-2 [Failed] 2a5c7736 test-mac-arm [Finished] 2a5c7736 ursa-i9-9960x [Finished] 2a5c7736 ursa-thinkcentre-m75q [Finished] 11647857 ec2-t3-xlarge-us-east-2 [Failed] 11647857 test-mac-arm [Finished] 11647857 ursa-i9-9960x [Finished] 11647857 ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Nov 01 '22 04:11 ursabot