arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-18186: [C++][MinGW] Make buildable with clang

Open kou opened this issue 3 years ago • 2 comments

Error1 (can't use [[gnu::dllexport]] with template):

cpp/src/arrow/util/int_util.cc:463:1: error: an attribute list cannot appear here
INSTANTIATE_ALL()
^~~~~~~~~~~~~~~~~
cpp/src/arrow/util/int_util.cc:454:3: note: expanded from macro 'INSTANTIATE_ALL'
  INSTANTIATE_ALL_DEST(uint8_t)  \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cpp/src/arrow/util/int_util.cc:444:3: note: expanded from macro 'INSTANTIATE_ALL_DEST'
  INSTANTIATE(uint8_t, DEST)       \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~
cpp/src/arrow/util/int_util.cc:440:12: note: expanded from macro 'INSTANTIATE'
  template ARROW_TEMPLATE_EXPORT void TransposeInts( \
           ^~~~~~~~~~~~~~~~~~~~~
cpp/src/arrow/util/visibility.h:47:31: note: expanded from macro 'ARROW_TEMPLATE_EXPORT'
#define ARROW_TEMPLATE_EXPORT ARROW_DLLEXPORT
                              ^~~~~~~~~~~~~~~
cpp/src/arrow/util/visibility.h:32:25: note: expanded from macro 'ARROW_DLLEXPORT'
#define ARROW_DLLEXPORT [[gnu::dllexport]]
                        ^~~~~~~~~~~~~~~~~~

Error2 (unused variable):

cpp/src/arrow/util/io_util.cc:1079:7: warning: variable 'oflag' set but not used [-Wunused-but-set-variable]
  int oflag = _O_CREAT | _O_BINARY | _O_NOINHERIT;
      ^

Error3 (missing field initializers):

cpp/src/arrow/util/io_util.cc:1545:29: warning: missing field 'InternalHigh' initializer [-Wmissing-field-initializers]
  OVERLAPPED overlapped = {0};
                            ^

kou avatar Oct 28 '22 06:10 kou

https://issues.apache.org/jira/browse/ARROW-18186

github-actions[bot] avatar Oct 28 '22 06:10 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Oct 28 '22 06:10 github-actions[bot]

PR looks fine a priori, but can we try to reduce those build times?

pitrou avatar Oct 31 '22 20:10 pitrou

can we try to reduce those build times?

Should we do in this pull request? Or can we defer this to ARROW-18039 ?

kou avatar Oct 31 '22 21:10 kou

We can defer this to ARROW-18039, but I'd like to make sure this isn't forgotten :-)

pitrou avatar Oct 31 '22 21:10 pitrou

OK! I'll do it in this month!

kou avatar Oct 31 '22 21:10 kou

Benchmark runs are scheduled for baseline = 85ae0d2e83a31a1a3e99c30c43e905c0fbdd0791 and contender = 474c7a1cb91298bcabe5bed7e0716c0b6ac7820c. 474c7a1cb91298bcabe5bed7e0716c0b6ac7820c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Failed :arrow_down:0.0% :arrow_up:0.0%] test-mac-arm [Finished :arrow_down:0.0% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.14% :arrow_up:0.0%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 474c7a1c ec2-t3-xlarge-us-east-2 [Failed] 474c7a1c test-mac-arm [Finished] 474c7a1c ursa-i9-9960x [Finished] 474c7a1c ursa-thinkcentre-m75q [Finished] 85ae0d2e ec2-t3-xlarge-us-east-2 [Failed] 85ae0d2e test-mac-arm [Finished] 85ae0d2e ursa-i9-9960x [Finished] 85ae0d2e ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Nov 02 '22 00:11 ursabot