arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-18118: [Release][Dev] Fix problems in 02-source.sh/03-binary-submit.sh for 10.0.0-rc0

Open kou opened this issue 2 years ago • 3 comments

SOURCE_PR in dev/release/02-source.sh didn't work because it refers undefined variable (rc_number is referred not rc). This change includes the following changes including the fix of the undefined variable problem:

  • Fix wrong variable use. (Variable name is also changed to adjust other variable names: release_candidate -> rc)
  • The ARROW_GITHUB_API_TOKEN environment variable is used for GitHub Personal Access Token but the CROSSBOW_GITHUB_TOKEN environment variable is used in others. So this also uses CROSSBOW_GITHUB_TOKEN. (Documentation is also updated. This change also includes unrelated minor updates. Sorry.)

dev/release/03-binary-submit.sh didn't work because:

  • It refers undefined variable (release_candidate_branch).
  • archery crossbow report-pr searches only base=master pull requests. (A verify pull request uses base=maint-X.Y.Z.)

This change fixes them. This change also adds --no-fetch to archery crossbow latest-prefix like other command lines to reduce execution time.

kou avatar Oct 21 '22 00:10 kou

https://issues.apache.org/jira/browse/ARROW-18118

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]

@raulcd What do you think about this?

kou avatar Oct 21 '22 00:10 kou

Benchmark runs are scheduled for baseline = 978ae86436e31af210da4959d55582e036a79bb9 and contender = 7ad4ced68f4135bc736ed2ffe48b5196b78d27ac. 7ad4ced68f4135bc736ed2ffe48b5196b78d27ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Failed :arrow_down:0.0% :arrow_up:0.0%] test-mac-arm [Finished :arrow_down:0.0% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.21% :arrow_up:0.0%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 7ad4ced6 ec2-t3-xlarge-us-east-2 [Failed] 7ad4ced6 test-mac-arm [Finished] 7ad4ced6 ursa-i9-9960x [Finished] 7ad4ced6 ursa-thinkcentre-m75q [Finished] 978ae864 ec2-t3-xlarge-us-east-2 [Failed] 978ae864 test-mac-arm [Finished] 978ae864 ursa-i9-9960x [Finished] 978ae864 ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Oct 30 '22 12:10 ursabot