apache
ARROW-17966: [C++] Adjust to new format for Substrait optional arguments
This PR currently depends on a non-official (PR fork) version of Substrait. We probably should not merge until the corresponding Substrait PR has merged.
https://github.com/substrait-io/substrait/pull/342
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: Ticket has not been started in JIRA, please click 'Start Progress'.
@bkietz Thanks for the review. I still need to take a look at the cmake changes but I'll try that out later.
Deferring the cmake changes to https://issues.apache.org/jira/browse/ARROW-18145
@bkietz I'm moving this to ready-for-review. @rtpsw has been trying to get Ibis / Arrow compatibility working and this PR enables that, even though it temporarily breaks us from the main branch of Substrait while we wait on https://github.com/substrait-io/substrait/pull/342 to merge. However, there is some work that is stacking up on top of this and branch management has started to cause some headaches.
Curious to get your thoughts on moving forward as-is with this PR, to make it easier for people working on integration, and addressing any remaining discrepancies (e.g. Enum vs string) in follow-up PRs.
The feature has now merged into Substrait. Unfortunately, it seems releases are automated on Sundays so this probably can't merge until after Sunday at which time I will change the version numbers to be 0.20.0.
@rok @bkietz Now that substrait version 0.20.0 is out, with this change, I think this is good to go.
Benchmark runs are scheduled for baseline = 7276c359e8be9b16ce5f122b81ec0bb89417224c and contender = 63f013cdb36d05f6f96a145aff3c6232470f2d02. 63f013cdb36d05f6f96a145aff3c6232470f2d02 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2
[Finished :arrow_down:0.2% :arrow_up:0.07%] test-mac-arm
[Finished :arrow_down:0.54% :arrow_up:0.0%] ursa-i9-9960x
[Finished :arrow_down:0.38% :arrow_up:0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 63f013cd ec2-t3-xlarge-us-east-2
[Finished] 63f013cd test-mac-arm
[Finished] 63f013cd ursa-i9-9960x
[Finished] 63f013cd ursa-thinkcentre-m75q
[Finished] 7276c359 ec2-t3-xlarge-us-east-2
[Finished] 7276c359 test-mac-arm
[Finished] 7276c359 ursa-i9-9960x
[Finished] 7276c359 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
