arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-17979: [JS] Update status docs with JS capabilities

Open domoritz opened this issue 3 years ago • 7 comments

domoritz avatar Oct 10 '22 17:10 domoritz

https://issues.apache.org/jira/browse/ARROW-17979

github-actions[bot] avatar Oct 10 '22 17:10 github-actions[bot]

I'm guessing this table is based off of the integration test support, and for these types, it appears there are not yet JS integration tests: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/datagen.py#L1588-L1664

ARROW-7900 is for null; not sure if there's an issue for the unions. Would it be easy to enable the integration tests for these types?

nealrichardson avatar Oct 10 '22 17:10 nealrichardson

Ahh, good to know. How involved is it to enable those tests? I don't have cycles to learn how to write integration tests right now, unfortunately.

domoritz avatar Oct 10 '22 17:10 domoritz

Ahh, good to know. How involved is it to enable those tests? I don't have cycles to learn how to write integration tests right now, unfortunately.

I'm not sure. If it were me, I'd start by removing the .skip_category('JS') lines I linked above, at least for the types you think should work, and see if the integration tests pass on CI.

The JS test runner is https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_js.py, which points at the files in https://github.com/apache/arrow/tree/master/js/bin. It's possible the tests will just work (if the implementation is correct), or it's possible that there is some JSON writer/reader specific to the integration tests that needs to be updated.

@zeroshade has been in here recently, enabling more Go tests, so he may be able to advise too.

nealrichardson avatar Oct 10 '22 18:10 nealrichardson

https://issues.apache.org/jira/browse/ARROW-7900 suggests to me that enabling the null test won't work. I'll try the other ones.

domoritz avatar Oct 10 '22 18:10 domoritz

Well, doesn't look look like I can just enable the integration tests.

Screenshot 2022-10-10 at 18 54 42

domoritz avatar Oct 10 '22 22:10 domoritz

Looking at the code in recordbatch.ts in collectDictionaries it looks like it is accessing data.dictionary where data is one of the children and is getting an undefined value for one of those children which is why it is failing.

zeroshade avatar Oct 11 '22 14:10 zeroshade

Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍

amol- avatar Mar 30 '23 17:03 amol-