arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-17406: [C++] Failing to build the C++ Lib with tests

Open kshitij12345 opened this issue 1 year ago • 7 comments

Ref: https://issues.apache.org/jira/browse/ARROW-17406

Pin boost-cpp to a version which doesn't raise warning.

kshitij12345 avatar Aug 13 '22 09:08 kshitij12345

https://issues.apache.org/jira/browse/ARROW-17406

github-actions[bot] avatar Aug 13 '22 09:08 github-actions[bot]

:warning: Ticket has no components in JIRA, make sure you assign one.

github-actions[bot] avatar Aug 13 '22 09:08 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Aug 13 '22 09:08 github-actions[bot]

We can use C++14 by specifying -DCMAKE_CXX_STANDARD=14.

kou avatar Aug 13 '22 10:08 kou

@kou Do other parts of the library support c++14?
(Also are you suggesting to add this flag to the build snippet on the webpage that walks through the build process?)

kshitij12345 avatar Aug 13 '22 11:08 kshitij12345

Yes. We have CI jobs for C++14 and C++17.

If our documents miss it, could you update our documents?

kou avatar Aug 13 '22 12:08 kou

Sure. Will look into that. Thanks @kou !

kshitij12345 avatar Aug 14 '22 08:08 kshitij12345

@kou Can we get this merged quickly to resolve CI failures?

pitrou avatar Aug 16 '22 08:08 pitrou

Which CI failures are you thinking? There are many CI failures for now (oh...) but it seems that there are no CI failures related to this.

kou avatar Aug 16 '22 08:08 kou

Sorry, I mean that merging this PR allows to fix AppVeyor, so we should do it quickly.

pitrou avatar Aug 16 '22 08:08 pitrou

Ah, I see. But this is not a real fix. This is just a workaround.

I'll take a look at the CI failure tomorrow. Please wait for a while. If you can't wait, you can merge this.

kou avatar Aug 16 '22 09:08 kou

Unblocking AppVeyor would be nice. As for the real fix, there is now some hope that we move to C++17 soon.

pitrou avatar Aug 16 '22 09:08 pitrou

Besides updating the doc, nothing actionable for me right? Thanks :)

cc: @pitrou @kou

kshitij12345 avatar Aug 16 '22 09:08 kshitij12345

Continuous discussion about AppVeyor failure: https://github.com/apache/arrow/pull/13903

(I think that we can fix the AppVeyor failure by removing CI jobs on AppVeyor instead of merging this change.)

kou avatar Aug 17 '22 06:08 kou