arrow icon indicating copy to clipboard operation
arrow copied to clipboard

Published 20 hours ago • verified publisher icon apache

ARROW-16817: [C++][Python] Fix segfaults in the ORC writer when unsupported datatypes are given

Open iajoiner opened this issue 2 years ago • 12 comments

iajoiner avatar Jul 06 '22 21:07 iajoiner

https://issues.apache.org/jira/browse/ARROW-16817

github-actions[bot] avatar Jul 06 '22 21:07 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Jul 06 '22 21:07 github-actions[bot]

Ok looks like the bug no longer exists in Arrow 8.0.0 likely due to the fix to https://issues.apache.org/jira/browse/ARROW-16025. These additional tests in C++ & Python are still good to add though just in case future updates break them.

iajoiner avatar Jul 07 '22 15:07 iajoiner

All tests have passed except for two that have nothing to do with the PR. Please review. Really thanks!

iajoiner avatar Jul 07 '22 15:07 iajoiner

@iajoiner Would you like to follow up on this?

pitrou avatar Jul 19 '22 09:07 pitrou

@iajoiner Ping.

pitrou avatar Aug 08 '22 15:08 pitrou

@pitrou Sorry yes. I’m mostly on the Rust side now but I will finish this one in a week.

iajoiner avatar Aug 08 '22 15:08 iajoiner

@iajoiner Looking forward to it! (and glad to hear the Arrow Rust community is ever growing :-))

pitrou avatar Aug 08 '22 15:08 pitrou

@iajoiner Are you willing to finish this?

pitrou avatar Aug 25 '22 11:08 pitrou

@wjones127 Perhaps you would like to take up this PR?

pitrou avatar Oct 18 '22 19:10 pitrou

@pitrou Are we still trying to get this into 10.0.0? Or can this be bumped to 11.0.0?

I can work on this regardless.

wjones127 avatar Oct 18 '22 20:10 wjones127

It can probably be bumped IMHO.

pitrou avatar Oct 18 '22 20:10 pitrou

Closing in favor of #14638

wjones127 avatar Nov 14 '22 23:11 wjones127