arrow-julia icon indicating copy to clipboard operation
arrow-julia copied to clipboard

Published 20 hours ago • verified publisher icon apache

Solving #293

Open complyue opened this issue 2 years ago • 1 comments

Attempt to solve #293, implementing Tables.partitions() for Arrow.Table turns out trivial enough, though I'm not clear what to do about companion test cases, documentation etc.

I'm lazy to have not excluded #296 from this PR, I'm open to draft another PR separated if you'd like, but the change set seems small, I hope you can have a quick look and decide what to do next.

complyue avatar Mar 04 '22 13:03 complyue

With an alternative solution #298, changes from #296 are removed from this PR, now it's only about Arrow.Table's Tables.partitions() implementation.

I suggest the commit history should be squashed, but don't have experience how to do that from my side, only seeing articles suggesting "Squash and merge" option of Github, but that seems only doable when merging a PR.

complyue avatar Mar 07 '22 08:03 complyue

Sorry for never getting to review/support this. I agree the functionality is good and this was a good start. Instead of returning a tuple of tables, I opted for a more lazy approach of just defining a custom iterator + tests: https://github.com/apache/arrow-julia/pull/443

quinnj avatar May 24 '23 03:05 quinnj