apisix icon indicating copy to clipboard operation
apisix copied to clipboard

help request: should we move the reload api from Admin API to Control API

Open spacewander opened this issue 3 years ago • 4 comments
trafficstars

Description

Currently, we have an API that reloads the plugin in the Admin API: https://apisix.apache.org/docs/apisix/terminology/plugin/#hot-reload. After years of usage, we find this design has some issues:

  1. its logic is complex
  2. it requires every node has the same plugin and static configuration.
  3. its usage is limited

As the reload API is mainly used for dev or debug purposes, moving this API into the control API would be more appreciated. What about your ideas?

Environment

  • APISIX version (run apisix version): 2.15.0
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):

spacewander avatar Sep 08 '22 09:09 spacewander

Agree +1 from me.

It's my understanding that plugin reload is a "foreign" operation in Admin API. It doesn't like other operations which focus on specific objects.

tokers avatar Sep 08 '22 09:09 tokers

Agree +1. In Admin API, it will be conflicted if there is a plugin called reload.

starsz avatar Sep 08 '22 10:09 starsz

agree +1 for me

tzssangglass avatar Sep 13 '22 04:09 tzssangglass

agree +1

guitu168 avatar Sep 13 '22 10:09 guitu168

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 07 '23 10:09 github-actions[bot]

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

github-actions[bot] avatar Sep 21 '23 10:09 github-actions[bot]