apisix icon indicating copy to clipboard operation
apisix copied to clipboard

feat: the consumer username supports hyphens `-`

Open AlinsRan opened this issue 3 years ago • 1 comments
trafficstars

Description

Background

At apisix-ingress-controller, We want to isolate resources through k8s namespace, for example, construct such a name namespace_username to differentiate consumers. K8s namespace supports hyphens -, but APISIX consumer username does not support https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L713.

$ url http://127.0.0.1:9080/apisix/admin/consumers \
 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
 {
     "username": "namespace-1_jack",
     "plugins": {
         "key-auth": {
             "key": "auth-one"
         }
     }
}'
# response
{"error_msg":"invalid configuration: property \"username\" validation failed: failed to match pattern \"^[a-zA-Z0-9_]+$\" with \"namespace-1_jack\""}

AlinsRan avatar Aug 31 '22 06:08 AlinsRan

If we don't have special considerations about the hyphen symbol, we can support it.

tokers avatar Aug 31 '22 09:08 tokers

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jan 23 '24 10:01 github-actions[bot]

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

github-actions[bot] avatar Feb 07 '24 10:02 github-actions[bot]