apisix icon indicating copy to clipboard operation
apisix copied to clipboard

Published 20 hours ago • verified publisher icon apache

feat: add openfunction plugin

Open jackkkkklee opened this issue 3 years ago • 0 comments

Description

support openfunction serverless platform implement proposal #7404

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

jackkkkklee avatar Aug 09 '22 09:08 jackkkkklee

@jackkkkklee Please make the CI pass. Thanks!

tokers avatar Aug 11 '22 09:08 tokers

@tokers Could you please re-run "CI / build (ubuntu-18.04, linux_openresty_1_19, t/plugin) (pull_request) " ? Timeout happened during building function.

jackkkkklee avatar Aug 15 '22 09:08 jackkkkklee

Could you please re-run "CI / build (ubuntu-18.04, linux_openresty_1_19, t/plugin) (pull_request) " ? Timeout happened during building function.

accord to: https://github.com/apache/apisix/runs/7833789308?check_suite_focus=true, maybe some error in test cases?

tzssangglass avatar Aug 15 '22 14:08 tzssangglass

Could you please re-run "CI / build (ubuntu-18.04, linux_openresty_1_19, t/plugin) (pull_request) " ? Timeout happened during building function.

accord to: https://github.com/apache/apisix/runs/7833789308?check_suite_focus=true, maybe some error in test cases? I think the root cause is network. In test case ,the server do not give response and test failed because of timeout in pre env step. accord to https://github.com/apache/apisix/runs/7833789308?check_suite_focus=true#step:11:568

jackkkkklee avatar Aug 15 '22 15:08 jackkkkklee

rerun

tzssangglass avatar Aug 15 '22 16:08 tzssangglass

@tzssangglass Could you please re-run "CI Centos7 / run ci on centos7 (t/admin t/cli t/config-center-yaml t/control t/core t/debug t/deploym" which has no contact with this pr？

jackkkkklee avatar Aug 17 '22 16:08 jackkkkklee

@tzssangglass Could you please re-run "CI Centos7 / run ci on centos7 (t/admin t/cli t/config-center-yaml t/control t/core t/debug t/deploym" which has no contact with this pr？

rerun

tzssangglass avatar Aug 18 '22 02:08 tzssangglass

@tzssangglass Could you please re-run the fail test?

jackkkkklee avatar Aug 18 '22 12:08 jackkkkklee

@tzssangglass Could you please re-run the fail test?

done

tzssangglass avatar Aug 18 '22 13:08 tzssangglass

@tzssangglass Could you please re-run the fail test?

done

Could you also re-run License checker / check-license (pull_request) ? Thanks

jackkkkklee avatar Aug 18 '22 14:08 jackkkkklee

Could you also re-run License checker / check-license (pull_request) ? Thanks

done

tzssangglass avatar Aug 19 '22 01:08 tzssangglass

@jackkkkklee Well done, now let's focus on the docs and test cases, I think the implementation is really good!

tokers avatar Aug 19 '22 01:08 tokers

@jackkkkklee If some of the golang codes you added are from the OpenFucntion repo, please update the LICENSE to mark them.

tokers avatar Aug 22 '22 01:08 tokers

@jackkkkklee If some of the golang codes you added are from the OpenFucntion repo, please update the LICENSE to mark them.

Added in the goland codes

jackkkkklee avatar Aug 22 '22 02:08 jackkkkklee

@tokers Could you please rerun ”CI / build (ubuntu-20.04, linux_openresty, t/node t/pubsub t/router t/script t/stream-node t/utils t/w... (pull_request) Failing after 17m...“?

jackkkkklee avatar Aug 26 '22 12:08 jackkkkklee

Could you please rerun ”CI / build (ubuntu-20.04, linux_openresty, t/node t/pubsub t/router t/script t/stream-node t/utils t/w... (pull_request) Failing after 17m...“?

done

tzssangglass avatar Aug 28 '22 17:08 tzssangglass