apisix
apisix copied to clipboard
feat: support Tencent Cloud Log Service
Description
apisix log util is more powerfull than nginx access log, and it's useful for debugging and replaying later.
Fixes # (7592)
Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)
Thanks for your contribution. But please add a license to each file and add test cases first.
any doc for testing? I have no exp for env setup & PERL testing framework...
any doc for testing? I have no exp for env setup & PERL testing framework...
See: https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md
any doc for testing? I have no exp for env setup & PERL testing framework...
See: https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md
tried.. I work on Mac, and now trapped in etcd configuration for more tesing case
I have a question: Is it that we can't do the test case to verify that this plugin is working correctly? Because it requires a Tencent account and to make sure that this account is always available.
I have a question: Is it that we can't do the test case to verify that this plugin is working correctly? Because it requires a Tencent account and to make sure that this account is always available.
We can inject a hook or mock into the code? Like: https://github.com/apache/apisix/blob/b3d4b464045b9bdfed3170cbd7a343ed5c40b24a/t/plugin/zipkin2.t#L35 https://github.com/apache/apisix/blob/b3d4b464045b9bdfed3170cbd7a343ed5c40b24a/t/plugin/opentelemetry.t#L553
I have same question too. But same question can be applie to other plugins that have env matters
I have same question too. But same question can be applie to other plugins that have env matters
@spacewander @tzssangglass after code related conversations closed, I will do the function test again for the related code modification.
We can inject a hook or mock into the code? Like:
@ychensha Let's do that for now, there's no better way to do it.
If hook is ok for now, I will add test code like otel plugin.
If hook is ok for now, I will add test code like otel plugin.
Don't be afraid. Feel free to contact me once you have trouble with the hook.
To fix https://github.com/apache/apisix/runs/7851928549?check_suite_focus=true Let's add tencent-cloud-cls to https://github.com/apache/apisix/blob/b0934f9ed45ec352c3de09f59e6912a7ba71936e/Makefile#L344
https://github.com/apache/apisix/runs/7861163309?check_suite_focus=true
Let's add the tencent-cloud-cls
@ychensha pls don't use force-push to update code, or reviews' comments may be ignore.
Let's merge master to make CI pass.
As this PR is big enough, let's open another PR for the doc.