apisix icon indicating copy to clipboard operation
apisix copied to clipboard

Remove deprecated configuration in the V3

Open spacewander opened this issue 2 years ago • 4 comments

Description

Let's remove the deprecated configuration in the APISIX v3, including:

  • [ ] health_check_retry option https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/cli/etcd.lua#L201
  • [ ] lua_shared_dicts https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/cli/ops.lua#L654-L655
  • [ ] audience in authz-keycloak https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/plugins/authz-keycloak.lua#L123-L129
  • [ ] upstream in mqtt-proxy https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/stream/plugins/mqtt-proxy.lua#L36
  • [ ] scheme in proxy-rewrite https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/plugins/proxy-rewrite.lua#L71
  • [ ] various apisix.real_ip_xxx options https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/cli/ngx_tpl.lua#L380
  • [ ] some configurations in syslog https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/plugins/syslog.lua#L62
  • [ ] some configurations in error-log-logger https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/plugins/error-log-logger.lua#L69-L74
  • [ ] drop support of service_protocol https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/schema_def.lua#L613
  • [ ] move the disable to _meta https://github.com/apache/apisix/blob/2385768cc004ee6ac9f6d50167d2eb671669f3c0/apisix/plugin.lua#L160

  • [ ] remove old configuration items like port_admin from the configuration file
  • [ ] remove the expression to determine whether to run the plugin or not inside some plugins (like fault-injection) since https://github.com/apache/apisix/pull/7453 is merged.

spacewander avatar Jul 18 '22 06:07 spacewander

Maybe we can remove old configuration items like port_admin from the configuration file as well? 🤔

bzp2010 avatar Jul 19 '22 07:07 bzp2010

Maybe we can remove old configuration items like port_admin from the configuration file as well? 🤔

LGTM

spacewander avatar Jul 20 '22 01:07 spacewander

We can also remove the expression to determine whether to run the plugin or not inside some plugins (like fault-injection) since https://github.com/apache/apisix/pull/7453 is merged.

spacewander avatar Jul 22 '22 06:07 spacewander

@tzssangglass Let's submit PRs to remove them when you have free time. Don't forget to submit PR per task so we can record them in the changelog.

spacewander avatar Aug 03 '22 09:08 spacewander