apisix icon indicating copy to clipboard operation
apisix copied to clipboard

bugfix: resolution when apisix reload eureka does not load the data

Open kongjun01 opened this issue 2 years ago • 4 comments

Description

https://github.com/apache/apisix/issues/7178

Fixes # (issue)

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

kongjun01 avatar Jul 11 '22 08:07 kongjun01

In the init and init_worker phases, we can't use lua-resty-http, so we use luasocket. But we don't need to replace the runtime procedure that uses lua-resty-http.

tzssangglass avatar Jul 12 '22 05:07 tzssangglass

In the init and init_worker phases, we can't use lua-resty-http, so we use luasocket. But we don't need to replace the runtime procedure that uses lua-resty-http.

This method is public at init and runtime.

kongjun01 avatar Jul 13 '22 07:07 kongjun01

This method is public at init and runtime.

I don't know what this means.

But replacing all lua-resty.http with luasocket is not acceptable. luasocket is a blocking call.

tzssangglass avatar Jul 14 '22 02:07 tzssangglass

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 12 '22 10:09 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Oct 10 '22 10:10 github-actions[bot]