apisix icon indicating copy to clipboard operation
apisix copied to clipboard

fix: `make deps` should check PCRE header in openresty-pcre-devel

Open kenhys opened this issue 3 years ago • 3 comments

Description

Already header file for OpenSSL (openresty-openssl111-devel) is checked, so do same thing for PCRE.

Without this fix, even though openresty-pcre-devel is installed, make deps fails like this:

Error: Failed installing dependency: https://luarocks.org/jsonschema-0.9.8-0.src.rock - Failed installing dependency: https://luarocks.org/lrexlib-pcre-2.9.1-1.src.rock - Could not find header file for PCRE No file pcre.h in /usr/local/include No file pcre.h in /usr/include No file pcre.h in /include You may have to install PCRE in your system and/or pass PCRE_DIR or PCRE_INCDIR to the luarocks command. Example: luarocks install lrexlib-pcre PCRE_DIR=/usr/local

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [ ] I have added tests corresponding to this change
  • [ ] I have updated the documentation to reflect this change
  • [ ] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

NOTE: utils/install-dependencies.sh or ci/centos7-ci.sh explicitly installs pcre-devel instead of openresty-pcre-devel, does it intentional?

kenhys avatar Jun 29 '22 09:06 kenhys

Please make the CI pass, thanks!

spacewander avatar Jun 30 '22 01:06 spacewander

@spacewander could you allow running workflows?

kenhys avatar Jul 01 '22 04:07 kenhys

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 01 '22 10:09 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Sep 29 '22 10:09 github-actions[bot]