apisix icon indicating copy to clipboard operation
apisix copied to clipboard

fix: openid foward original id token

Open cgmEdi opened this issue 5 months ago • 6 comments

Description

Issue: https://github.com/apache/apisix/issues/10275 https://github.com/apache/apisix/issues/12438 Summary: add a config option "set original id token header" so that the original id_token that was stored in the sesssion (enc_id_token) gets fowarded as the new header "X-Id-Token-Original".

In my company, we have a use case, where the donwstream needs the original id_token so that it can perform a token exchange.

Which issue(s) this PR fixes:

Fixes #10275 #12438

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

cgmEdi avatar Jul 16 '25 22:07 cgmEdi

I need to check the original issue before reviewing this PR.

Baoyuantop avatar Jul 21 '25 09:07 Baoyuantop

Hi @cgmEdi, there is a conflicting file that needs to be resolved.

Baoyuantop avatar Jul 23 '25 00:07 Baoyuantop

Hi @cgmEdi, there is a conflicting file that needs to be resolved.

Hi @Baoyuantop, the conflict is resolved now :).

cgmEdi avatar Jul 23 '25 04:07 cgmEdi

Hi @cgmEdi, please fix failed ci.

Baoyuantop avatar Jul 24 '25 09:07 Baoyuantop

Hi @cgmEdi, any updates?

Baoyuantop avatar Jul 28 '25 06:07 Baoyuantop

The issue associated with this PR has been closed due to lack of activity and no agreement has been reached with the primary maintainer.

Baoyuantop avatar Nov 06 '25 02:11 Baoyuantop

Since there have been no further responses to the comments in the issue https://github.com/apache/apisix/issues/12438#issuecomment-3134684961, we believe the validity of this request is controversial and have decided to close this PR for now. Please feel free to reopen it if you have any further questions. Thank you for your contribution @cgmEdi .

Baoyuantop avatar Dec 17 '25 03:12 Baoyuantop