apisix icon indicating copy to clipboard operation
apisix copied to clipboard

bug: Kubernetes discovery determines whether to enable endpointslice

Open MrLinMH opened this issue 1 year ago • 2 comments

Current Behavior

In the source code, when judging whether to watch endpoint slices, watch_endpoint_slices_schema is used, as follows: image

But what is defined in the schema is watch_endpoint_slices: image

When determining whether to watch endpoint slices, you should use conf.watch_endpoint_slices , watch_endpoint_slices_schema is only a local variable in the lua file apisix/discovery/kubernetes/schema.lua . It will not appear in the configuration item schema of discovery kubernetes. The actual variable used in the schema is watch_endpoint_slices .

Expected Behavior

No response

Error Logs

No response

Steps to Reproduce

PR: https://github.com/apache/apisix/pull/10916/files

Environment

APISIX version: 3.9.0 (master branch also has this problem)

MrLinMH avatar Oct 09 '24 05:10 MrLinMH

It looks like the relevant E2E test cases also need further refinement.

@MrLinMH PR to fix the issue?

zhoujiexiong avatar Oct 11 '24 05:10 zhoujiexiong

Hey @zhoujiexiong , I did like to work on this issue. Can you please assign it to me.

slayer321 avatar Oct 11 '24 17:10 slayer321

emmmm,Does this mean kubernetes discovery is not worked?

naah69 avatar Nov 26 '24 13:11 naah69