apisix icon indicating copy to clipboard operation
apisix copied to clipboard

feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents

Open wistefan opened this issue 1 year ago • 21 comments

Description

In order to make decisions based on the request body, the OPA-Plugin will also forward the body when configured to do so.

Fixes #11387

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

wistefan avatar Oct 08 '24 14:10 wistefan

Is there anything I can do to get this PR forward?

wistefan avatar Nov 06 '24 11:11 wistefan

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jan 06 '25 10:01 github-actions[bot]

@wistefan Please synchronize the master code to trigger all CI

moonming avatar Jan 07 '25 03:01 moonming

@wistefan Please synchronize the master code to trigger all CI

@moonming Thank you for the review, I updated.

wistefan avatar Jan 07 '25 07:01 wistefan

Hello! If I want this new implementation with the request body, what should I do?

Hi @wistefan, please synchronize the latest master branch code to trigger the test.

Baoyuantop avatar Mar 25 '25 02:03 Baoyuantop

Hi @wistefan, please fix failed ci

Baoyuantop avatar Apr 01 '25 06:04 Baoyuantop

Hi @wistefan, do you have time to continue working on this PR?

Baoyuantop avatar Apr 03 '25 05:04 Baoyuantop

@Baoyuantop Yes, most likely beginning of next week

wistefan avatar Apr 03 '25 06:04 wistefan

@Baoyuantop Could you please appove the ci workflows?

wistefan avatar Apr 17 '25 10:04 wistefan

@wistefan, please fix failed ci

Baoyuantop avatar Apr 23 '25 02:04 Baoyuantop

Hello! What is the status of this?

Need to fix the failed CI, waiting for a response from the author.

Baoyuantop avatar May 08 '25 03:05 Baoyuantop

Hello! Any news?

Hi, sorry I will take care as soon as I find time. @LuciaCabanillasRodriguez help would be very welcome, do you have the time to take a look at the test failures?

wistefan avatar May 28 '25 06:05 wistefan

Hi, sorry I will take care as soon as I find time. @LuciaCabanillasRodriguez help would be very welcome, do you have the time to take a look at the test failures?

Hello! I tried to push a file to fix one of the issues, but I received a forbidden message. In any case, I solved it locally by running:

make lint ./utils/reindex t/plugin/opa3.t

Regarding the error in t/discovery/consul_dump.t, I see that the test fails because the expected response from Consul isn’t being returned: got: '' expected: '{"service_a":[{"host":"127.0.0.1","port":30511,"weight":1}]}'

It seems like either the service_a isn’t being registered properly in Consul during the test, or the endpoint isn’t responding as expected.

As for the other warnings and errors like: failed to do SSL handshake: certificate verify failed http_init(): failed to load the configuration: connection refused

These appear to be related to missing services (like Consul or Etcd) or SSL verification issues, but I’m not entirely sure how to fix it with certainty.

Good! I could remove one issue, the other one remains! Any help?? I would need some guidance on how to fix it

Maybe we can merge the master branch.

Baoyuantop avatar Jun 18 '25 01:06 Baoyuantop

Maybe we can merge the master branch. Is there any update here?

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 15 '25 10:11 github-actions[bot]