apisix icon indicating copy to clipboard operation
apisix copied to clipboard
verified publisher icon apache

help request: why configuring `protocol_name` in the `mqtt-proxy` plugin

Open kayx23 opened this issue 1 year ago • 5 comments

Description

Plugin doc: https://apisix.apache.org/docs/apisix/plugins/mqtt-proxy/

Currently protocol_name is a required parameter and the doc says it's generally set to MQTT. Upon checking the test cases and code, it is still not clear to me why this is a configurable parameter. Why shouldn't it be hard-coded and what other value than MQTT could it be?

Environment

  • APISIX version (run apisix version): 3.10.0

kayx23 avatar Sep 19 '24 08:09 kayx23

This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 04 '25 10:09 github-actions[bot]

Hi @membphis, do you have any impression of this issue?

Baoyuantop avatar Sep 05 '25 02:09 Baoyuantop

this field should be an optional field, welcome PR to fix it:

Image

membphis avatar Sep 19 '25 07:09 membphis

I'm interested in working on this issue. Could you provide more context about what you're looking for? Any additional details about requirements or constraints would be helpful.

tysoncung avatar Oct 09 '25 02:10 tysoncung

Hi @tysoncung, we should adjust protocol_name to be an optional parameter.

Baoyuantop avatar Oct 11 '25 04:10 Baoyuantop

Hi guys I am new here and would like to continue this issue.

I will implement the sanity test as well to check for the schema.

YapWC avatar Dec 22 '25 08:12 YapWC