apisix icon indicating copy to clipboard operation
apisix copied to clipboard

fix(log-rotate): skip access log when enable_access_log is set to false

Open flearc opened this issue 1 year ago • 14 comments

Description

Fixes #11309

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [ ] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

flearc avatar May 31 '24 10:05 flearc

Hi This means that the widget you used has its own subscription object, and it has rpcEnabled: false by default because it is not a control widget. It’s impossible to just rewrite the parameter in the current subscription. Therefore, you need to create a custom subscription https://github.com/thingsboard/thingsboard/blob/cb37450470892f82a3787a1e989f3463295f1055/ui-ngx/src/app/core/api/widget-subscription.ts#L196 Also, it will be better if you use RPC widget as template https://thingsboard.io/docs/user-guide/contribution/widgets-development/#rpc-control-widget

mykhailokornieiev avatar Jun 17 '24 14:06 mykhailokornieiev

Closed due inactivity

mykhailokornieiev avatar Jul 01 '24 15:07 mykhailokornieiev