apisix icon indicating copy to clipboard operation
apisix copied to clipboard

feat: add hide_credentials for multi-auth plugin

Open madhawa-gunasekara opened this issue 1 year ago • 5 comments

Fixes https://github.com/apache/apisix/issues/11069 11069

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

madhawa-gunasekara avatar May 15 '24 10:05 madhawa-gunasekara

Hi @shreemaan-abhishek.

Can you please review this pull request?

madhawa-gunasekara avatar May 15 '24 13:05 madhawa-gunasekara

BTW, regarding the error in the Chinese documentation lint, you can try merging the master branches into your work branch, they are already fixed.

bzp2010 avatar May 28 '24 09:05 bzp2010

@bzp2010 @shreemaan-abhishek Can you review again

madhawa-gunasekara avatar Jun 13 '24 08:06 madhawa-gunasekara

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 12 '24 10:08 github-actions[bot]

@bzp2010 is this PR ready for merge?

moonming avatar Aug 12 '24 10:08 moonming

I just wanted to kindly check in on the status of PR #11256 . I understand there may be other priorities, but I was wondering if there’s anything that needs further clarification or adjustments on my part to help move it forward.

madhawa-gunasekara avatar Sep 05 '24 16:09 madhawa-gunasekara

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 05 '24 10:11 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Dec 15 '24 10:12 github-actions[bot]