feat: support for Service Discovery Across Multiple Nacos Clusters

[ShenFeng312]

Description

Fixes #10799

Checklist

• [ ] I have explained the need for this PR and the problem it solves
• [ ] I have explained the changes or the new features added to this PR
• [ ] I have added tests corresponding to this change
• [ ] I have updated the documentation to reflect this change
• [ ] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

[shreemaan-abhishek]

please fix the linter

[ShenFeng312]

@monkeyDluffy6017 hello~ These errors seem to be unrelated to this PR.

[monkeyDluffy6017]

Could you add test cases to cover this?

[ShenFeng312]

Could you add test cases to cover this?

I will add test cases next week

[zll600]

@monkeyDluffy6017 hello~ These errors seem to be unrelated to this PR.

The ci problem has been fixed by https://github.com/apache/apisix/pull/10959. Please merge latest master.

[shreemaan-abhishek]

CI is still failing

[ShenFeng312]

@shreemaan-abhishek hello~ i dont know how to fix this error

[shreemaan-abhishek]

@ShenFeng312 try using --- response_body chomp

[ShenFeng312]

@shreemaan-abhishek The 'others' field represents a list of additional Nacos configurations. Since the previous schema for Nacos configuration was an object, directly changing it to an array would render existing configurations incompatible. Therefore, I've utilized the 'others' field to extend this functionality. Of course, if we decide that backward compatibility is not necessary, we can redesign this configuration schema. Currently, my implementation involves adding a new layer of 'nacosName' within the original 'applications' map. This layer corresponds to different Nacos configurations. Additionally, the asynchronous tasks for fetching Nacos configurations have been modified from fetching from a single Nacos instance to fetching from multiple instances. They are organized into different maps based on the 'name' specified in the configuration.

[shreemaan-abhishek]

please pay attention here: https://github.com/apache/apisix/pull/10950#discussion_r1577950606

[ShenFeng312]

please pay attention here: #10950 (comment)

fixed

[shreemaan-abhishek]

can you also mention that host is deprecated now (both in code and docs). Here is an example:

https://apisix.apache.org/docs/apisix/plugins/kafka-logger/#attributes

[ShenFeng312]

can you also mention that host is deprecated now (both in code and docs). Here is an example:

https://apisix.apache.org/docs/apisix/plugins/kafka-logger/#attributes

Yes

[shreemaan-abhishek]

I think this line is enough: https://github.com/apache/apisix/pull/10950/commits/6d2dcc2b8cbdb400ef39a2f0c860609be8648beb?diff=split&w=0#diff-8d872babc717e9d733641b56bfc530ef98751fbe4e68f08d79b2b83109c22fffR302

we can skip these:

And it think it's better if the comment says: "deprecated, use nacos.hosts instead"

[ShenFeng312]

Hello, can I continue with this PR? Or do I need to create a new one? Or are we not planning to support this feature? @shreemaan-abhishek

[bzp2010]

I think this really should go on, let me see. No new PR is needed and I am open to adding this feature, we can do that.

[bzp2010]

@ShenFeng312 Except for a few minor issues that could be modified, this is an excellent job.

[github-actions[bot]]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.