apisix icon indicating copy to clipboard operation
apisix copied to clipboard

feat(discovery): support endpointslices in kubernetes discovery

Open dongjiang1989 opened this issue 1 year ago • 7 comments

Description

This PR add support endpointslices in kubernetes discovery

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [ ] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

dongjiang1989 avatar Feb 05 '24 13:02 dongjiang1989

@dongjiang1989 please explain why this is needed, thanks.

shreemaan-abhishek avatar Feb 06 '24 05:02 shreemaan-abhishek

@dongjiang1989 please explain why this is needed, thanks.

@shreemaan-abhishek thanks for your review.

EndpointSlices provide a simple way to track network endpoints within a Kubernetes cluster. They offer a more scalable and extensible alternative to Endpoints.

ref: https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

dongjiang1989 avatar Feb 06 '24 06:02 dongjiang1989

Could you add test cases to cover this?

monkeyDluffy6017 avatar Feb 06 '24 09:02 monkeyDluffy6017

@monkeyDluffy6017 @shreemaan-abhishek Please re-check. Thanks

dongjiang1989 avatar Feb 08 '24 01:02 dongjiang1989

@zhixiongdu027 Could you help to review this pr?

monkeyDluffy6017 avatar Feb 18 '24 03:02 monkeyDluffy6017

We should update the documentation for this feature.

AlinsRan avatar Feb 18 '24 09:02 AlinsRan

We should update the documentation for this feature.

Thanks. Added it

dongjiang1989 avatar Feb 19 '24 05:02 dongjiang1989

/test

dongjiang1989 avatar Feb 20 '24 01:02 dongjiang1989

@AlinsRan @shreemaan-abhishek @monkeyDluffy6017 please re-check,thanks

dongjiang1989 avatar Feb 21 '24 16:02 dongjiang1989