help request: should we use docker compose v2 in CI
Description
the ENV_DOCKER_COMPOSE uses docker-compose command which is v1 version of docker compose.
https://github.com/apache/apisix/blob/847db2a2d9084791f6c337bbe6e7c1b9c2f43728/Makefile#L40
According to the offical doc: https://docs.docker.com/compose/. The v1 version stopped receving updates. So do we need to consider migrating to v2?
Environment
- APISIX version (run
apisix version): master - Operating system (run
uname -a): ubuntu 20.04 - OpenResty / Nginx version (run
openresty -Vornginx -V): - etcd version, if relevant (run
curl http://127.0.0.1:9090/v1/server_info): - APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run
luarocks --version):
agree! for now, we may can use like ENV_DOCKER_COMPOSE=docker compose .... make ...
agree! for now, we may can use like
ENV_DOCKER_COMPOSE=docker compose .... make ...
yep. The github runner support the v2. https://github.com/actions/runner-images/blob/ubuntu20/20240116.2/images/ubuntu/Ubuntu2004-Readme.md
@shreemaan-abhishek how do u think? i agree with him, we may can update this
In my opinion it's not wise to change the CI for simple things.