apisix icon indicating copy to clipboard operation
apisix copied to clipboard

help request: should we use docker compose v2 in CI

Open zll600 opened this issue 1 year ago • 4 comments

Description

the ENV_DOCKER_COMPOSE uses docker-compose command which is v1 version of docker compose. https://github.com/apache/apisix/blob/847db2a2d9084791f6c337bbe6e7c1b9c2f43728/Makefile#L40

According to the offical doc: https://docs.docker.com/compose/. The v1 version stopped receving updates. So do we need to consider migrating to v2?

Environment

  • APISIX version (run apisix version): master
  • Operating system (run uname -a): ubuntu 20.04
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):

zll600 avatar Jan 24 '24 14:01 zll600

agree! for now, we may can use like ENV_DOCKER_COMPOSE=docker compose .... make ...

Vacant2333 avatar Jan 24 '24 14:01 Vacant2333

agree! for now, we may can use like ENV_DOCKER_COMPOSE=docker compose .... make ...

yep. The github runner support the v2. https://github.com/actions/runner-images/blob/ubuntu20/20240116.2/images/ubuntu/Ubuntu2004-Readme.md

zll600 avatar Jan 24 '24 15:01 zll600

@shreemaan-abhishek how do u think? i agree with him, we may can update this

Vacant2333 avatar Jan 25 '24 15:01 Vacant2333

In my opinion it's not wise to change the CI for simple things.

shreemaan-abhishek avatar Jan 26 '24 06:01 shreemaan-abhishek