apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

fix: export apisix type for encoding/json package

Open Belyenochi opened this issue 2 years ago • 6 comments

Type of change:

  • [x] Bugfix
  • [ ] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What this PR does / why we need it:

Resolved #912 The encoding/json package and similar packages ignore unexported fields, so we should export these type.

Belyenochi avatar Mar 14 '22 14:03 Belyenochi

hi @tao12345666333 , I tried doing some export renames and fixes for some type issues, I'm not sure if my naming is in line with the project specification, could you please give me some advice.

Belyenochi avatar Mar 14 '22 15:03 Belyenochi

Sure! Thanks for your contributions!

I will finish the review as soon as possible (within a day

tao12345666333 avatar Mar 14 '22 15:03 tao12345666333

Codecov Report

Merging #920 (58f2637) into master (75098d1) will increase coverage by 0.00%. The diff coverage is 12.12%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   31.90%   31.91%           
=======================================
  Files          72       73    +1     
  Lines        7899     7900    +1     
=======================================
+ Hits         2520     2521    +1     
  Misses       5103     5103           
  Partials      276      276           
Impacted Files Coverage Δ
pkg/ingress/apisix_pluginconfig.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/kube/translation/translator.go 46.07% <0.00%> (ø)
pkg/ingress/ingress.go 6.59% <40.00%> (ø)
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11bd92b...58f2637. Read the comment docs.

codecov-commenter avatar Mar 14 '22 15:03 codecov-commenter

All "apisix.apache.org/v2beta3" needs to remain as they are, since this is the version information we use

tao12345666333 avatar Mar 15 '22 04:03 tao12345666333

All "apisix.apache.org/v2beta3" needs to remain as they are, since this is the version information we use

I totally agree, it was my omission.

Belyenochi avatar Mar 15 '22 05:03 Belyenochi

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 01 '22 01:08 github-actions[bot]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 01 '22 01:10 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Oct 31 '22 01:10 github-actions[bot]