apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

feat: make multiple controllers handle different ApisixRoute CRDs #578

Open Donghui0 opened this issue 3 years ago • 4 comments

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • [ ] Bugfix

  • [x] New feature provided

  • [ ] Improve performance

  • [ ] Backport patches

  • Related issues #578 #592



New feature or improvement

make multiple controllers handle different ApisixRoute CRDs


Backport patches

  • Why need to backport?

  • Source branch

  • Related commits and pull requests

  • Target branch

Donghui0 avatar Jul 15 '21 04:07 Donghui0

Codecov Report

Merging #593 (1ca7df9) into master (6e22838) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 1ca7df9 differs from pull request most recent head c8456e2. Consider uploading reports for the commit c8456e2 to get more accurate results

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   41.69%   41.69%           
=======================================
  Files          90       90           
  Lines        7702     7702           
=======================================
  Hits         3211     3211           
  Misses       4127     4127           
  Partials      364      364           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 15 '21 04:07 codecov-commenter

Here is an issue related

gxthrj avatar Jul 16 '21 02:07 gxthrj

Thanks for your contribution, Please resolve the conflict if you have time, let's move forward.

tao12345666333 avatar Mar 04 '22 16:03 tao12345666333

there are some conflicts, and I want the feature to just be added to the v2 version of the API

https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-1221021549

tao12345666333 avatar Aug 19 '22 19:08 tao12345666333

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 19 '22 01:10 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Nov 19 '22 01:11 github-actions[bot]

@Donghui0 Do you have time to work on this PR? Maybe I can help with that.

Gallardot avatar Dec 13 '22 03:12 Gallardot

Yesterday I had an online meeting with @Donghui0 and @Gallardot. After discussion, we will use this PR instead of #1523, and @Donghui0 will complete this PR.

I've just resolved the code merge conflict in this PR.

For some basic technical solutions can refer to https://github.com/apache/apisix-ingress-controller/pull/1523#issuecomment-1429344801

I will also submit a more complete description at https://github.com/apache/apisix-ingress-controller/issues/592 later

Thank you all!

tao12345666333 avatar Feb 17 '23 06:02 tao12345666333

@Donghui0 Please see https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-1449264770 I have added more details.

tao12345666333 avatar Mar 03 '23 09:03 tao12345666333

CI fails, I think @AlinsRan can help. PTAL

tao12345666333 avatar Mar 20 '23 01:03 tao12345666333