apisix-ingress-controller
apisix-ingress-controller copied to clipboard
feat: make multiple controllers handle different ApisixRoute CRDs #578
Please answer these questions before submitting a pull request
-
Why submit this pull request?
-
[ ] Bugfix
-
[x] New feature provided
-
[ ] Improve performance
-
[ ] Backport patches
-
Related issues #578 #592
New feature or improvement
make multiple controllers handle different ApisixRoute CRDs
Backport patches
-
Why need to backport?
-
Source branch
-
Related commits and pull requests
-
Target branch
Codecov Report
Merging #593 (1ca7df9) into master (6e22838) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head 1ca7df9 differs from pull request most recent head c8456e2. Consider uploading reports for the commit c8456e2 to get more accurate results
@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 41.69% 41.69%
=======================================
Files 90 90
Lines 7702 7702
=======================================
Hits 3211 3211
Misses 4127 4127
Partials 364 364
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Here is an issue related
Thanks for your contribution, Please resolve the conflict if you have time, let's move forward.
there are some conflicts, and I want the feature to just be added to the v2 version of the API
https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-1221021549
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
@Donghui0 Do you have time to work on this PR? Maybe I can help with that.
Yesterday I had an online meeting with @Donghui0 and @Gallardot. After discussion, we will use this PR instead of #1523, and @Donghui0 will complete this PR.
I've just resolved the code merge conflict in this PR.
For some basic technical solutions can refer to https://github.com/apache/apisix-ingress-controller/pull/1523#issuecomment-1429344801
I will also submit a more complete description at https://github.com/apache/apisix-ingress-controller/issues/592 later
Thank you all!
@Donghui0 Please see https://github.com/apache/apisix-ingress-controller/issues/592#issuecomment-1449264770 I have added more details.
CI fails, I think @AlinsRan can help. PTAL