apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

bug: Missing "client/skip_mtls_uri_regex" in CRD ApisixTls in the schema (version 2)

Open rlaflamme opened this issue 9 months ago • 1 comments

Current Behavior

We are using the version 1.8.0 that come from the helm chart 0.14.0. But the feature is not there too in the latest release 1.8.2

From the branch 1.8.0, The feature is not present in the schema (file conf/apisix-schema.json). here

                "client": {
                    "required": [
                        "ca"
                    ],
                    "type": "object",
                    "properties": {
                        "ca": {
                            "minLength": 128,
                            "maxLength": 65536,
                            "type": "string"
                        },
                        "depth": {
                            "minimum": 0,
                            "default": 1,
                            "type": "integer"
                        }
                    }
                },
                "create_time": {
                    "type": "integer"
                },
...

However it is there in the samples (samples/deploy/crd/v1/ApisixTls.yaml)

here

      schema:
        openAPIV3Schema:
          description: ApisixTls defines SSL resource in APISIX.
          type: object
          properties:
            apiVersion:
              description: 'APIVersion defines the versioned schema of this representation
                of an object. Servers should convert recognized schemas to the latest
                internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
              type: string
            kind:
              description: 'Kind is a string value representing the REST resource
                this object represents. Servers may infer this from the endpoint the
                client submits requests to. Cannot be updated. In CamelCase. More
                info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
              type: string
            metadata:
              type: object
            spec:
              description: ApisixTlsSpec is the specification of ApisixSSL.
              type: object
              required:
                - hosts
                - secret
              properties:
                ingressClassName:
                  type: string
                client:
                  description: ApisixMutualTlsClientConfig describes the mutual TLS
                    CA and verify depth
                  type: object
                  properties:
                    caSecret:
                      description: ApisixSecret describes the Kubernetes Secret name
                        and namespace.
                      type: object
                      required:
                        - name
                        - namespace
                      properties:
                        name:
                          type: string
                          minLength: 1
                        namespace:
                          type: string
                          minLength: 1
                    depth:
                      type: integer
                    skip_mtls_uri_regex:
                      type: array
                      items:
                        type: string
...

Expected Behavior

I was expecting to be present in the Schema. Latest release (1.8.2) don't show it either

Error Logs

No response

Steps to Reproduce

  • deploy helm release 0.14.0 (ingress-controller 1.8.0)

Environment

artifact.io

rlaflamme avatar May 06 '24 16:05 rlaflamme

This issue has been marked as stale due to 90 days of inactivity. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 05 '24 01:08 github-actions[bot]

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

github-actions[bot] avatar Sep 04 '24 01:09 github-actions[bot]