apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

feat: Add description parameter to ApisixConsumer

Open jorgenll opened this issue 1 year ago • 19 comments

Type of change:

  • [x] New feature provided

What this PR does / why we need it:

Add support for define the AsipixConsumer description on the CRD and propagate this information to the Consumer synchronized on APISIX. I need to define the description of the consumer but the CRD don't support it. I've try to use a label as alternative but the Kubernetes spec don't allow whitespaces on labels.

fixes #2222

Pre-submission checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [x] Have you added corresponding test cases?
  • [x] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

jorgenll avatar Apr 24 '24 11:04 jorgenll

I've fix the e2e tests (I forgot the name conversion process...) and the lint problems.

I also review in my local environment the unit test and run successfully, but in the workflow the file cmd/ingress/ingress_test.go, test TestRotateLog, fails with connection refuse errors. Anyone can help my with this error?

Finally, I've a doubt: the release 1.8.1 was released on April 15th, but several files still use the 1.8.0 version (the Makefile for example) and the master branch diverge from this release (compare). I need to perform any change in my PR? Thanks!

jorgenll avatar Apr 25 '24 06:04 jorgenll

Hi! @pottekkat, could you execute again the workflow? @Revolyssup, could you help me clarify the error with the unit-test? Thanks all!!

jorgenll avatar Apr 29 '24 06:04 jorgenll

Trigged a rerun.

pottekkat avatar Apr 29 '24 10:04 pottekkat

Great, the workflow works fine and all is green. Thanks!!

jorgenll avatar Apr 29 '24 18:04 jorgenll

Hi @pottekkat, how should review the PR?

jorgenll avatar May 16 '24 07:05 jorgenll

Hi @pottekkat , @Revolyssup, any update on this feature? Thanks!

jorgenll avatar Jun 04 '24 10:06 jorgenll

Hi @pottekkat, @Revolyssup, do you need anything to review the pull request? Thanks

jorgenll avatar Jun 23 '24 21:06 jorgenll

Hi @pottekkat , could you relaunch the workflow? Thanks!

jorgenll avatar Jun 29 '24 09:06 jorgenll

Hi @AlinsRan, any feedback or comment on this pull request? Thanks!

jorgenll avatar Jul 08 '24 19:07 jorgenll

@AlinsRan, do you see any problem on the PR? We need this feature to complete a migration to APISIX. Additionally, do you think that this feature could be included in the next release? When it's planned? Thanks!!

jorgenll avatar Jul 30 '24 20:07 jorgenll

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 29 '24 01:09 github-actions[bot]

Hi. Any comment about the proposed change? @AlinsRan , @Revolyssup

jorgenll avatar Sep 29 '24 07:09 jorgenll