apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

feat: add Gateway UDPRoute

Open stillfox-lee opened this issue 3 years ago • 8 comments

Type of change:

  • [ ] Bugfix
  • [x] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What this PR does / why we need it:

Just implement basic usage. Need other PR to support UDPRoute weight feature after Upstream can create nodes by weight.

stillfox-lee avatar Aug 27 '22 16:08 stillfox-lee

@tao12345666333 Could you please help me rerun CI again? The unit-test passed in my local env.

stillfox-lee avatar Aug 28 '22 03:08 stillfox-lee

sure

tao12345666333 avatar Aug 28 '22 04:08 tao12345666333

Codecov Report

Merging #1278 (496442c) into master (40f1372) will decrease coverage by 0.26%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
- Coverage   40.73%   40.47%   -0.27%     
==========================================
  Files          77       78       +1     
  Lines        7030     7076      +46     
==========================================
  Hits         2864     2864              
- Misses       3851     3897      +46     
  Partials      315      315              
Impacted Files Coverage Δ
pkg/providers/gateway/translation/gateway.go 0.00% <0.00%> (ø)
.../providers/gateway/translation/gateway_udproute.go 0.00% <0.00%> (ø)
pkg/providers/gateway/translation/translator.go 0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 28 '22 05:08 codecov-commenter

@stillfox-lee could you please resolve the conflicts? thanks!

tao12345666333 avatar Sep 13 '22 07:09 tao12345666333

Some CI tasks failed, do you have time to deal with them? Because some logic changes were made in some recently merged PRs A breaking change occurred. #1251

tao12345666333 avatar Sep 14 '22 08:09 tao12345666333

Some CI tasks failed, do you have time to deal with them? Because some logic changes were made in some recently merged PRs A breaking change occurred. #1251

I will fix it ASAP.

stillfox-lee avatar Sep 14 '22 09:09 stillfox-lee

@tao12345666333 I think this PR is ready for review.

stillfox-lee avatar Sep 16 '22 01:09 stillfox-lee

Except for the comments above, everything else is LGTM. Also, could you merge master branch to resolve conflicts?

Then can merge this one.

tao12345666333 avatar Sep 21 '22 07:09 tao12345666333

@tao12345666333 It looks like CI needs your approval to run.

stillfox-lee avatar Oct 10 '22 15:10 stillfox-lee

First-time contributors need a maintainer to approve running workflows. Learn more.

@tao12345666333, Please approve the CI. It's weird that GitHub always identifies me as first time contributor.

stillfox-lee avatar Oct 11 '22 10:10 stillfox-lee

This is a known issue and I'm already looking for a solution

tao12345666333 avatar Oct 11 '22 11:10 tao12345666333

@tao12345666333 Please trigger CI again...

stillfox-lee avatar Oct 11 '22 15:10 stillfox-lee

The failed test case seems not related to this PR.

stillfox-lee avatar Oct 12 '22 01:10 stillfox-lee

all passed!

tao12345666333 avatar Oct 12 '22 02:10 tao12345666333