apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

fix: log Secret name instead of all data

Open zaunist opened this issue 1 year ago • 2 comments

Type of change:

  • [ ] Bugfix
  • [x] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What this PR does / why we need it:

fix https://github.com/apache/apisix-ingress-controller/issues/1045

Pre-submission checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [ ] Have you added corresponding test cases?
  • [ ] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

zaunist avatar Aug 04 '22 07:08 zaunist

Codecov Report

Merging #1216 (853b227) into master (7115cef) will increase coverage by 0.13%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
+ Coverage   42.64%   42.78%   +0.13%     
==========================================
  Files          73       73              
  Lines        6462     6477      +15     
==========================================
+ Hits         2756     2771      +15     
  Misses       3409     3409              
  Partials      297      297              
Impacted Files Coverage Δ
pkg/config/config.go 66.34% <0.00%> (+1.34%) :arrow_up:
cmd/ingress/ingress.go 80.70% <0.00%> (+2.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 04 '22 07:08 codecov-commenter

sorry for delay. please resolve conflicts. thanks!

tao12345666333 avatar Aug 10 '22 18:08 tao12345666333

@tao12345666333 PTAL, thanks.

zaunist avatar Aug 15 '22 03:08 zaunist

ping @lingsamuel for review, thanks

tao12345666333 avatar Aug 16 '22 04:08 tao12345666333