apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

request help: should we use githook for pre-commit operation

Open fatpa opened this issue 2 years ago • 1 comments

Issue description

During the contribute document, we have some pre-commit to-do tasks to do manually. I think we should use the githook function to avoid manual jobs.

Environment

Nothing about the environment.

fatpa avatar Jun 07 '22 08:06 fatpa

I have thought about this way, it can bring certain benefits.

But most open source projects don't choose it.

On the other hand, these operations are not required for every commit.

I tend to keep these things in the hands of CI, giving more freedom to contributors

tao12345666333 avatar Jun 07 '22 14:06 tao12345666333