apisix-ingress-controller icon indicating copy to clipboard operation
apisix-ingress-controller copied to clipboard

log: shouldn't log secret object

Open lingsamuel opened this issue 2 years ago • 7 comments

http://github.com/apache/apisix-ingress-controller/blob/3d0b9769894197ba3138cd3b96d775ba2163e0c8/pkg/ingress/secret.go#L376-L376

lingsamuel avatar May 26 '22 12:05 lingsamuel

the link is invalid.

tao12345666333 avatar May 26 '22 14:05 tao12345666333

https://github.com/apache/apisix-ingress-controller/blob/49dd015085a68ce4c26ba60076ef281ed71af2aa/pkg/ingress/secret.go#L376-L379

yes, I think we should only log secret object's name

tao12345666333 avatar May 26 '22 14:05 tao12345666333

get

PGDream avatar Jun 02 '22 07:06 PGDream

@PGDream do you want to pick up this task?

tao12345666333 avatar Jun 02 '22 11:06 tao12345666333

@PGDream do you want to pick up this task?

y

PGDream avatar Jun 02 '22 14:06 PGDream

@PGDream Assigned, thanks

tao12345666333 avatar Jun 02 '22 23:06 tao12345666333

[WeOpen Star]I would like to help

zaunist avatar Aug 11 '22 06:08 zaunist