nginx connection configurage to values.yaml attribute

[PGDream]

with main snippet dont modify nginx command worker_rlimit_nofile、events.worker_connections、events.use`

[PGDream]

values.yaml add events.use purpose APACHE APISIX ngx_tpl.lua file override events.use command on nginx.conf

[tao12345666333]

plz check the CI errors

[PGDream]

plz check the CI errors

@tao12345666333 lost reviewer!

[PGDream]

This is more convenient for later expansion and structuring. Is it considered possible to change this way?

[tao12345666333]

@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

[PGDream]

@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

good idea

[PGDream]

@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

done

[tao12345666333]

It's on my queue, I will do the final review today.

[PGDream]

@tokers where not change of log parameters?

[tokers]

@tokers where not change of log parameters?

FYI: https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml#L166

[PGDream]

@tokers where not change of log parameters?

FYI: https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml#L166

modify more configure,account upgrade may error..

[tokers]

No. If you don't modify them, what's the point of introducing the nginx_config.logs?

[PGDream]

@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

No. If you don't modify them, what's the point of introducing the nginx_config.logs?

@PGDream In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration. ?

how to solve then above problems?

[tao12345666333]

@PGDream What problem are you having now?

[PGDream]

In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

excuse me, how do it?

[tokers]

In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

excuse me, how do it?

Let's add the nginx.log field but at the same time, don't change the log parameters.

[PGDream]

In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

excuse me, how do it?

Let's add the nginx.log field but at the same time, don't change the log parameters.

that`s it now

[tokers]

In order to maintain compatibility, we can support both configuration methods at the same time. After 3 versions, remove the old configuration.

excuse me, how do it?

Let's add the nginx.log field but at the same time, don't change the log parameters.

that`s it now

See https://github.com/apache/apisix-helm-chart/pull/268/files#r871183026. You need to change all places that refer to the old log fields. And mark the log fields as deprecated.