apisix-docker icon indicating copy to clipboard operation
apisix-docker copied to clipboard

fix: fail when use standalone mode (#541)

Open fvilla-netnix opened this issue 11 months ago • 6 comments

This aims to fix an existing issue that causes containerized deployments to fail when a config file is provided by the user while in standalone mode.

This is because when in standalone mode the docker-entrypoint.sh script tries to create the config.yaml file or update it's keys to ensure it is setup correctly.

My fix allow users to use read-only files by removing write operations from the script and replaces them with checks and warnings to stop users from using invalid config files.

fvilla-netnix avatar Mar 12 '24 18:03 fvilla-netnix

Thanks for the PR. Debian standalone CI is failing. Please take a look.

kayx23 avatar Mar 12 '24 19:03 kayx23

Hi there, still failing

kayx23 avatar Mar 12 '24 22:03 kayx23

Think I fixed it now. I had broken some config.yaml files.

ghost avatar Mar 13 '24 15:03 ghost

Hi @fvilla-netnix unfortunately tests are still falling. For future reference, it is easier to open PRs to the main branch of your fork to test CIs. This requires no approvals from maintainers and you could get immediate feedback. Since this PR is already opened, I'm not sure if you could still open one to your main branch; likely not.

kayx23 avatar Mar 14 '24 04:03 kayx23

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jun 06 '24 10:06 github-actions[bot]

issue is still present

kayx23 avatar Jun 06 '24 10:06 kayx23

I am also facing this issue, as described in #557. It seems like this PR has gone stale. Is there any way I can contribute to this PR to help get it merged? I’d be happy to make any necessary changes or updates.

TheShubhendra avatar Jul 22 '24 07:07 TheShubhendra

@TheShubhendra you can open a new PR if you would like

kayx23 avatar Jul 22 '24 15:07 kayx23