apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

Plugin is still working after disable it

Open mujinhuakai opened this issue 2 years ago • 2 comments

Issue description

In the plugin list page, click cofig to open the config drawer, disable the plugin and click submit. It says success and we can't see this plugin in the plugin list. We expect the plugin is disabled, but actually, the plugin is still working.

We see in the brower devTool, the put request add a "disable" the same layer of "_meta", but the "_meta.disable" do not change image

After we send a request with the "_meta.disable" set to true, the plugin is then actually not working

It seems that the "_meta.disable" determine whether the plugin is diable, the disable in the the same layer of "_meta", determine whether the plugin can be seen in the plugin list

Expected behavior

We expect the plugin is disabled and not working after disabled in the plugin list page

How to Reproduce

1、open the plugin list page, we see the plugins that is working 2、select one of the plugin, for example client-control, and click the config button, we see the cofig drawer image

3、click disable button switch and click submit image

4、we can see the plugin disappear from the plugin list. we see the put request body image

5、try to send request with some data to the server, we see it faild, because the request body exceeds the "max_body_size " 6、send a same request with curl command with the the same params as we see in step 4 in the devTools. except that the _meta.disable set to true

7、do the same as step 5, we can send request sucessfully , becasue the plugin client-control is stoped

Screenshots

No response

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run etcd --version):
  • apisix-dashboard version, if have:
  • Browser version, if have:

Additional context

No response

mujinhuakai avatar Apr 13 '23 11:04 mujinhuakai