apisix-dashboard
apisix-dashboard copied to clipboard
fix:ant-table unable to request(#2613)
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
What changes will this PR take into?
Accoding to this idea ( https://github.com/ant-design/pro-components/issues/1921 ) , I upgraded its version.
Related issues
fix/resolve #2613
Checklist:
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
Hi @Huanghaiting, can you help get the CI passed? For failed frontend e2e tests, you can verify locally. Refer to https://apisix.apache.org/docs/dashboard/front-end-e2e/
Codecov Report
Merging #2641 (b80e6b9) into master (e68b3aa) will decrease coverage by
12.27%
. The diff coverage is87.05%
.
:exclamation: Current head b80e6b9 differs from pull request most recent head bece36a. Consider uploading reports for the commit bece36a to get more accurate results
@@ Coverage Diff @@
## master #2641 +/- ##
===========================================
- Coverage 68.29% 56.02% -12.28%
===========================================
Files 139 133 -6
Lines 3694 3618 -76
Branches 872 854 -18
===========================================
- Hits 2523 2027 -496
- Misses 1171 1591 +420
Flag | Coverage Δ | |
---|---|---|
frontend-e2e-test | 56.02% <87.05%> (-12.28%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
web/src/pages/Route/List.tsx | 56.02% <16.66%> (-2.73%) |
:arrow_down: |
web/src/pages/Route/Create.tsx | 79.52% <80.00%> (-3.81%) |
:arrow_down: |
web/src/components/ActionBar/ActionBar.tsx | 76.92% <100.00%> (ø) |
|
web/src/pages/Consumer/List.tsx | 87.80% <100.00%> (-3.87%) |
:arrow_down: |
web/src/pages/Proto/List.tsx | 100.00% <100.00%> (ø) |
|
...b/src/pages/Proto/components/ProtoDrawer/index.tsx | 88.88% <100.00%> (+0.42%) |
:arrow_up: |
web/src/pages/SSL/Create.tsx | 86.04% <100.00%> (+1.83%) |
:arrow_up: |
web/src/pages/SSL/List.tsx | 88.46% <100.00%> (+3.46%) |
:arrow_up: |
web/src/pages/Service/Create.tsx | 95.00% <100.00%> (+0.35%) |
:arrow_up: |
web/src/pages/Service/List.tsx | 94.87% <100.00%> (+0.75%) |
:arrow_up: |
... and 29 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hello, @Huanghaiting It looks like the test failed because some dom names changed due to the upgrade, you need to confirm and change the correct dom names:
Hi @Huanghaiting, the frontend E2E tests are not very stable, so if there is an error, but it is verified locally by you, please let us know to help you re-run it.
@Huanghaiting Thank you for your contribution.