apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon apache

feat(route): make front-end adapt `route` v3 api modification

Open tomtiao opened this issue 3 years ago • 1 comments

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • [ ] Bugfix
  • [x] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

Adapt the route part of the front-end for the v3 API interface.

It seems that /labels/route is missing in v3. This spawns Network Error notification which prevents tests from passing. Should I query all route data and collect the labels?

Tests of route fails due to:

  • create process depends on other modules, like upstream which haven't been adapted yet
  • missing apis in v3

I have modified some of the frontend code using the info in the Postman api docs. Tell me if I could do better.

Code that block tests

  • batch-delete-route test

    • /labels/route notification prevents cy from clicking the button
    • missing api

  • create-route-* test

    • create process depends on upstream

  • data-loader-import test

    • missing api

  • search-route test

    • depends on create process

  • table-auto-jump-when-no-data test

    • /labels/route notification prevents cy from clicking the button

Related issues

fix/resolve #2636

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [ ] Have you added corresponding test cases?
  • [ ] Have you modified the corresponding document?
  • [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

tomtiao avatar Oct 14 '22 04:10 tomtiao

Deploy Preview for apisix-dashboard ready!

Name Link
Latest commit 358382ff844ef5f349cb738ab2edf514181b013d
Latest deploy log https://app.netlify.com/sites/apisix-dashboard/deploys/6348e8aee1a8a7000a1d2f02
Deploy Preview https://deploy-preview-2639--apisix-dashboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 14 '22 04:10 netlify[bot]

Hello, @tomtiao Do you have any questions for the CI?

guoqqqi avatar Oct 19 '22 06:10 guoqqqi

For features that are not yet supported, can we disable the corresponding test?

guoqqqi avatar Oct 19 '22 07:10 guoqqqi

Hello, @tomtiao Do you have any questions for the CI?

I wonder if we could turn off the tests. 😂

tomtiao avatar Oct 20 '22 13:10 tomtiao

I wonder if we could turn off the tests. 😂

I think you can temporarily close the irrelevant tests, the relevant tests need to be fixed

guoqqqi avatar Oct 25 '22 02:10 guoqqqi