apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

feat: Proxy the related requests to apisix

Open monkeyDluffy6017 opened this issue 3 years ago • 3 comments

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • [ ] Bugfix
  • [x] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

The backend of apisix-dashboard currently has many of the same interfaces as apisix, and there are differences in implementation, resulting in inconsistent between apisix and apisix-dashboard, and every change to the apisix interface will result in changes to apisix-dashboard. This is a lot of work. The apisix-dashboard backend has now been modified to only proxy related requests to apisix, and is no longer implemented separately.

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [x] Have you added corresponding test cases?
  • [x] Have you modified the corresponding document?
  • [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

monkeyDluffy6017 avatar Oct 09 '22 09:10 monkeyDluffy6017

Deploy Preview for apisix-dashboard ready!

Name Link
Latest commit d888b01e9217718f7d4ce0b93455252019c6724d
Latest deploy log https://app.netlify.com/sites/apisix-dashboard/deploys/6348d12e66c563000880034b
Deploy Preview https://deploy-preview-2634--apisix-dashboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 09 '22 09:10 netlify[bot]

Codecov Report

Merging #2634 (857c66d) into next (005ed14) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #2634   +/-   ##
=======================================
  Coverage   41.72%   41.72%           
=======================================
  Files          15       15           
  Lines         405      405           
=======================================
  Hits          169      169           
  Misses        213      213           
  Partials       23       23           
Flag Coverage Δ
backend-unit-test 41.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 09 '22 09:10 codecov-commenter

And, why have many CIs been removed?

@bzp2010 I just want to test backend-e2e-test-v3, i will add the deleted ci files later

monkeyDluffy6017 avatar Oct 14 '22 09:10 monkeyDluffy6017