apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

feat: allow starting error report when use systemd

Open bzp2010 opened this issue 3 years ago • 1 comments

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • [ ] Bugfix
  • [ ] New feature provided
  • [x] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

Currently, when users use systemd, if manager-api fails to start, users will not receive a report and need to check it themselves using systemctl status. This PR improves this problem, when systemctl start, it will block and wait for the startup to complete, when the startup fails, the user will receive the report immediately.

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [ ] Have you added corresponding test cases?
  • [ ] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

bzp2010 avatar Sep 20 '22 06:09 bzp2010

Codecov Report

Merging #2620 (190eac4) into master (b777d99) will increase coverage by 2.34%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2620      +/-   ##
==========================================
+ Coverage   68.50%   70.85%   +2.34%     
==========================================
  Files         134       98      -36     
  Lines        3553     4947    +1394     
  Branches      867      267     -600     
==========================================
+ Hits         2434     3505    +1071     
- Misses       1119     1149      +30     
- Partials        0      293     +293     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.09% <0.00%> (?)
backend-unit-test 50.58% <ø> (?)
frontend-e2e-test 65.70% <ø> (-2.81%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/cmd/root.go 72.72% <0.00%> (ø)
web/src/helpers.tsx 19.67% <0.00%> (-50.82%) :arrow_down:
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) :arrow_down:
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) :arrow_down:
web/src/pages/Consumer/List.tsx 69.44% <0.00%> (-22.23%) :arrow_down:
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) :arrow_down:
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) :arrow_down:
web/src/components/Plugin/PluginPage.tsx 82.00% <0.00%> (-15.00%) :arrow_down:
web/src/app.tsx 87.87% <0.00%> (-12.13%) :arrow_down:
web/src/components/Plugin/UI/cors.tsx 71.11% <0.00%> (-11.12%) :arrow_down:
... and 164 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 20 '22 06:09 codecov-commenter