apisix-dashboard icon indicating copy to clipboard operation
apisix-dashboard copied to clipboard

feat: support regex_uri attribute in redirect plugin (#2434)

Open hqh15 opened this issue 2 years ago • 6 comments

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • [ ] Bugfix
  • [x] New feature provided
  • [ ] Improve performance
  • [ ] Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2434

Checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [x] Have you added corresponding test cases?
  • [ ] Have you modified the corresponding document?
  • [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

hqh15 avatar Aug 05 '22 07:08 hqh15

Codecov Report

Merging #2568 (2009c72) into master (06a7118) will increase coverage by 1.96%. The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
+ Coverage   68.58%   70.54%   +1.96%     
==========================================
  Files         133      116      -17     
  Lines        3501     3185     -316     
  Branches      861      801      -60     
==========================================
- Hits         2401     2247     -154     
+ Misses       1100      938     -162     
Flag Coverage Δ
frontend-e2e-test 70.54% <94.73%> (+1.96%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/constants.ts 100.00% <ø> (ø)
web/src/pages/Route/components/Step1/MetaView.tsx 97.84% <93.54%> (-2.16%) :arrow_down:
web/src/pages/Route/transform.ts 81.02% <100.00%> (+0.60%) :arrow_up:
...mponents/Upstream/components/active-check/Host.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
...mponents/Upstream/components/active-check/Port.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
...mponents/Upstream/components/active-check/Type.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
...nents/Upstream/components/active-check/Timeout.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
...ents/Upstream/components/active-check/HttpPath.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
...s/Upstream/components/active-check/Concurrency.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
...tream/components/active-check/Healthy/Interval.tsx 33.33% <0.00%> (-66.67%) :arrow_down:
... and 61 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Aug 05 '22 07:08 codecov-commenter

hello, @Sh1-5 also need to update this case image

guoqqqi avatar Aug 05 '22 07:08 guoqqqi

Hi, @Sh1-5 Please check the logic when configuring the route, the default value of radio is not available 🤔 image

guoqqqi avatar Aug 05 '22 08:08 guoqqqi

Hi, @Sh1-5 Please check the logic when configuring the route, the default value of radio is not available 🤔 image

ok, I found it just now.

hqh15 avatar Aug 05 '22 09:08 hqh15

also cc @SkyeYoung PTAL~

guoqqqi avatar Aug 05 '22 09:08 guoqqqi

hello @Sh1-5 any update? Have you encountered any problems?

guoqqqi avatar Aug 07 '22 14:08 guoqqqi